Re: [PATCH v2.1 0/3] btrfs-progs: Check and repair invalid root item generation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12.08.19 г. 9:34 ч., Qu Wenruo wrote:
> Kernel is going to reject invalid root generation.
> 
> Consider the existing checks are causing some error reports, we should
> handle such problem in advance, so that's the patchset is going to do,
> check and repair such invalid root generation.
> 
> Changelog:
> v2:
> - Use existing recow_extent_buffer() to do the repair
> 
> v2.1:
> - Add beacon file to allow lowmem mode repair for newly added test case.
> 
> Qu Wenruo (3):
>   btrfs-progs: check/lowmem: Check and repair root generation
>   btrfs-progs: check/original: Check and repair root item geneartion
>   btrfs-progs: fsck-tests: Add test case for invalid root generation
> 
>  check/main.c                                  |  57 +++++++-----------
>  check/mode-common.c                           |  36 +++++++++++
>  check/mode-common.h                           |   1 +
>  check/mode-lowmem.c                           |  17 ++++++
>  check/mode-lowmem.h                           |   1 +
>  .../.lowmem_repairable                        |   0
>  .../default_case.img                          | Bin 0 -> 3072 bytes
>  7 files changed, 76 insertions(+), 36 deletions(-)
>  create mode 100644 tests/fsck-tests/041-invalid-root-generation/.lowmem_repairable
>  create mode 100644 tests/fsck-tests/041-invalid-root-generation/default_case.img
> 

The patchset looks rather trivial - just use recow_extent_buffer when
you find a root with larger generation. So:

Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux