Btrfs qgroup has one big performance overhead for certain snapshot drop.
Current btrfs_drop_snapshot() will try its best to find the highest
shared node, and just drop one ref of that common node.
This behavior is good for minimize extent tree modification, but a
disaster for qgroup.
Example:
Root 300 Root 301
A B
| \ / |
| X |
| / \ |
C D
/ \ / \
E F G H
/ \ / \ / \ / \
I J K L M N O P
In above case, if we're dropping root 301, btrfs_drop_snapshot() will
only drop one ref for tree block C and D.
But for qgroup, tree blocks E~P also have their owner changed, from
300, 301 to 300 only.
Currently we use btrfs_qgroup_trace_subtree() to manually re-dirty tree
block E~P. And since such ref change happens in one transaction for each
ref drop, we can't split the overhead to different transactions.
This could cause qgroup extent record flood, hugely damage performance
or even cause OOM for too many qgroup extent records.
Unfortunately unlike previous qgroup + balance optimization, we can't
really do much to help.
So to make the problem less obvious, let's just pause qgroup and resume
it for snapshot drop, and queue a rescan automatically.
For independent subvolume or small snapshot, we don't really need to do
such pause/rescan workaround, as regular per-tree-block dropping is
pretty qgroup friendly.
One existing test case, btrfs/179 can trigger the behavior and test the
patchset. Although this patchset will change the snapshot drop behavior,
thus leaving the test harder to detect the original detect lock.
Changelog:
v1:
- Prevent race between quota enable/disable and quota pause/resume
Qu Wenruo (3):
btrfs: Refactor btrfs_clean_one_deleted_snapshot() to use fs_info
other than root
btrfs: qgroup: Introduce quota pause infrastrucutre
btrfs: Pause and resume qgroup for snapshot drop
fs/btrfs/ctree.h | 3 +-
fs/btrfs/disk-io.c | 9 +++--
fs/btrfs/extent-tree.c | 13 ++++++-
fs/btrfs/qgroup.c | 87 +++++++++++++++++++++++++++++++++++++++++-
fs/btrfs/qgroup.h | 3 ++
fs/btrfs/relocation.c | 4 +-
fs/btrfs/transaction.c | 8 ++--
fs/btrfs/transaction.h | 2 +-
8 files changed, 114 insertions(+), 15 deletions(-)
--
2.22.0
