On Wed, Jul 24, 2019 at 07:47:33PM +0800, Qu Wenruo wrote:
>
>
> On 2019/7/24 下午6:52, David Sterba wrote:
> > On Wed, Jul 24, 2019 at 01:07:05PM +0800, Qu Wenruo wrote:
> >> When running misc-test/034, we got unexpected log output:
> >> [TEST/misc] 033-filename-length-limit
> >> [TEST/misc] 034-metadata-uuid
> >> Checking btrfstune logic
> >> Checking dump-super output
> >> Checking output after fsid change
> >> Checking for incompat textual representation
> >> Checking setting fsid back to original
> >> Testing btrfs-image restore
> >>
> >> This is caused by commit 2570cff076b1 ("btrfs-progs: test: cleanup misc-tests/034")
> >> which uses _log facility which also populates stdout.
> >>
> >> Revert to echo "$*" >> "$RESULTS" to remove the noise.
> >
> > Yes to remove the noise but the idea was to avoid manual redirections to
> > $RESULTS, so we need a new helper or adjust _log.
> >
>
> OK, I'll change _log to avoid populating stdout.
There are more calls to 'echo ... $RESULTS' in several tests, so that
would be good to unify.
> BTW, the reason I didn't change _log is at commit e547fdb16667
> ("btrfs-progs: tests, add more common helpers") it's using _log in
> _run_mayfail(), but now it's not.
I see, the code has evolved. The helpers like run_mayfail are allowed to
use the raw calls (or can use own internal helpers if that makes sense),
and we can make _log exclusively used by tests, once it does print to
stdout.
> So some commits are doing conflicting modification during that cleanup.
Yeah.
