On 2019/7/24 下午6:52, David Sterba wrote:
> On Wed, Jul 24, 2019 at 01:07:05PM +0800, Qu Wenruo wrote:
>> When running misc-test/034, we got unexpected log output:
>> [TEST/misc] 033-filename-length-limit
>> [TEST/misc] 034-metadata-uuid
>> Checking btrfstune logic
>> Checking dump-super output
>> Checking output after fsid change
>> Checking for incompat textual representation
>> Checking setting fsid back to original
>> Testing btrfs-image restore
>>
>> This is caused by commit 2570cff076b1 ("btrfs-progs: test: cleanup misc-tests/034")
>> which uses _log facility which also populates stdout.
>>
>> Revert to echo "$*" >> "$RESULTS" to remove the noise.
>
> Yes to remove the noise but the idea was to avoid manual redirections to
> $RESULTS, so we need a new helper or adjust _log.
>
OK, I'll change _log to avoid populating stdout.
BTW, the reason I didn't change _log is at commit e547fdb16667
("btrfs-progs: tests, add more common helpers") it's using _log in
_run_mayfail(), but now it's not.
So some commits are doing conflicting modification during that cleanup.
Thanks,
Qu
Attachment:
signature.asc
Description: OpenPGP digital signature
