> On 16 Jul 2019, at 9:26 AM, Qu Wenruo <quwenruo.btrfs@xxxxxxx> wrote: > > > > On 2019/7/15 下午11:09, Nikolay Borisov wrote: >> >> >> On 15.07.19 г. 17:42 ч., Anand Jain wrote: >>> To help debug device scan issues, add verbose option to btrfs device scan. >>> >>> Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx> >> >> I fail to see what this patch helps for. We get the path in case of >> errors, in case of success what good could the path be ? > > AFAIK it would provide an easy way to debug blkid related bug. > > E.g. scan only works on some devices and misses some devices. > > So it makes sense to me, although "debug" would be more suitable in this > case. As the objective is to show the devices scanned with its device path, so IMO verbose would be suitable? Its a small change, can be modified at the time of integration. Will send V2 with a nit fix to use bool instead of int. Thanks, Anand
