On Wed, Jun 19, 2019 at 09:54:16AM +0300, Nikolay Borisov wrote:
>
>
> On 18.06.19 г. 21:00 ч., David Sterba wrote:
> > Print the error messages using the helpers that also print the
> > filesystem identification.
> >
> > Signed-off-by: David Sterba <dsterba@xxxxxxxx>
> > ---
> > fs/btrfs/extent_io.c | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> > index 8634eda07b7a..a6ad2f6f2bf7 100644
> > --- a/fs/btrfs/extent_io.c
> > +++ b/fs/btrfs/extent_io.c
> > @@ -524,9 +524,11 @@ static int insert_state(struct extent_io_tree *tree,
> > {
> > struct rb_node *node;
> >
> > - if (end < start)
> > - WARN(1, KERN_ERR "BTRFS: end < start %llu %llu\n",
> > - end, start);
> > + if (end < start) {
> > + btrfs_err(tree->fs_info,
> > + "insert state: end < start %llu %llu", end, start);
> > + WARN_ON(1);
> > + }
>
> nit: if (WARN_ON(end < start))
> btrfs_err(...)
That's not the same. The message is printed after the warning and with
panic-on-warn it's not printed at all. WARN prints the format string
first, so btrfs_err+WARN_ON preserves that.
