On 9:05 19/06, Nikolay Borisov wrote: > > > On 19.06.19 г. 3:35 ч., Goldwyn Rodrigues wrote: > > Simplification. > > No point passing the tree variable when it can be evaluated > > from inode. > > > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> > > The patch is good, however, there are several calls to find_ > lock_delalloc_range in btrfs tests so you'd need to fix those > invocations, otherwise compilation of the in-kernel test suite will fails. > > fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start, > fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start, > fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start, > fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start, > fs/btrfs/tests/extent-io-tests.c: found = find_lock_delalloc_range(inode, &tmp, locked_page, &start, > > Oh, I missed the test, even if it was listed as EXPORT_FOR_TESTS. Looking at the tests, it seems it needs to work on a different io_tree than in the inode. So, I suppose this patch should NOT be included for the sake of tests. Perhaps we should use wrapper functions for simplifications. -- Goldwyn
