On 18.06.19 г. 21:00 ч., David Sterba wrote:
> Print the error messages using the helpers that also print the
> filesystem identification.
>
> Signed-off-by: David Sterba <dsterba@xxxxxxxx>
> ---
> fs/btrfs/extent_io.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 8634eda07b7a..a6ad2f6f2bf7 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -524,9 +524,11 @@ static int insert_state(struct extent_io_tree *tree,
> {
> struct rb_node *node;
>
> - if (end < start)
> - WARN(1, KERN_ERR "BTRFS: end < start %llu %llu\n",
> - end, start);
> + if (end < start) {
> + btrfs_err(tree->fs_info,
> + "insert state: end < start %llu %llu", end, start);
> + WARN_ON(1);
> + }
nit: if (WARN_ON(end < start))
btrfs_err(...)
> state->start = start;
> state->end = end;
>
> @@ -536,7 +538,8 @@ static int insert_state(struct extent_io_tree *tree,
> if (node) {
> struct extent_state *found;
> found = rb_entry(node, struct extent_state, rb_node);
> - pr_err("BTRFS: found node %llu %llu on insert of %llu %llu\n",
> + btrfs_err(tree->fs_info,
> + "found node %llu %llu on insert of %llu %llu",
> found->start, found->end, start, end);
> return -EEXIST;
> }
>
