On 2019/6/17 下午9:18, David Sterba wrote: > On Mon, Jun 17, 2019 at 05:06:22PM +0800, Qu Wenruo wrote: >> And for a btrfs specific question, why we have packed attribute for >> btrfs_key? >> I see no specific reason to make a CPU native structure packed, not to >> mention we already have btrfs_disk_key. > > For that one there's no reason to use packed and we can go further and > reorder the members so that the offset is right after objectid, ie. both > at aligned addresses. Yep, exactly what I want to do. > I have a patch for that but I still need to > validate that. A quick grep shows no direct btrfs_key usage in ioctl structures. Thus I think existing test cases should be enough to validate it. Thanks, Qu
Attachment:
signature.asc
Description: OpenPGP digital signature
