On Mon, May 27, 2019 at 07:19:54PM +0200, David Sterba wrote: > 1-5 are reviewed and ok, 6 and 13 should be reworked, 7-12 is ok. I > can't put the branch to next yet due to the csum formatting "issues" but > will do once you resend. Should be ok just 6 and 13 as they're > independent. I'd still like to hold back 13/13. SHA-256 doesn't seem to be well received by the community as the "slow" hash and using a plain SHA-256 is not sufficient for the dm-verity/fs-verity like approach I intend to implement in subsequent patches. For the record, the current idea is to use a HMAC(SHA-256) as checksum algorithm with a key provided at mkfs and mount time. -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
