Re: [PATCH v5 RESEND] btrfs-progs: dump-tree: add noscan option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/4/19 3:28 PM, Qu Wenruo wrote:


On 2019/4/11 下午2:52, Nikolay Borisov wrote:


On 11.04.19 г. 7:53 ч., Qu Wenruo wrote:


On 2019/4/4 下午3:29, Anand Jain wrote:
From: Anand Jain <Anand.Jain@xxxxxxxxxx>

The cli 'btrfs inspect dump-tree <dev>' will scan for the partner devices
if any by default.

So as of now you can not inspect each mirrored device independently.

This patch adds noscan option, which when used won't scan the system for
the partner devices, instead it just uses the devices provided in the
argument.

For example:
   btrfs inspect dump-tree --noscan <dev> [<dev>..]

So you can specify multiple devices, just like kernel "device=" mount
option.

Then I don't think --noscan is a good naming, while I don't have any
good alternative, as the --degraded is no better.

How about skipscan ?

I still prefer "--device=", no surprise, anyone who used "device=" mount
option knows what it is.

 --device is already taken.

usage: btrfs inspect-internal dump-tree [options] <device> [<device> ..]
::
-d|--device print only device info: tree root, chunk and device trees


The only problem is, when only using one device, it will be super stupid:
   dump-tree --device /dev/sda /dev/sda

If this doesn't sound good, then --noscan is good enough AFAIK.

  IMO --noscan OR --degraded is good.

Thanks, Anand



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux