On Mon, May 13, 2019 at 09:11:14AM +0200, Johannes Thumshirn wrote: > On Fri, May 10, 2019 at 03:30:36PM +0300, Nikolay Borisov wrote: > [...] > > > > nit: Might be a good idea to turn that into an enum for self-documenting > > purposes. Perhaps in a different patch. > > Thought about this as well, but I thought I remembered a patch series from > David where he turned everything not being an on-disk format to enums. > > This discuraged me from actually doing the switch. I'd be more than happy if I > could just use an enum. Enum is fine, but named constants that are part of on-disk format should be spell the exact value, ie. not relying on the auto-increment of enum values.
