Re: [PATCH 14/17] btrfs: directly call into crypto framework for checsumming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 10, 2019 at 01:54:30PM +0000, Chris Mason wrote:
> Looking at the callers of btrfs_csum_final() and btrfs_csum_data(), lets 
> just pass the shash_desc from the callers.  That way you don't have to 
> poke at memcpy and shash_desc_ctx().
 
I wanted to avoid spreading knowledge about the crypto api to deep into the
filesystem. I'd actually loved to have something akin to ubifs'
ubifs_info::log_hash but wasn't really sure how to handle concurrency.

> I'm a little worried about stack usage (at least 360 bytes), but worst 
> case we can do some percpu gymnastics.
> 
> -chris

-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux