On Fri, May 10, 2019 at 04:27:38PM +0300, Nikolay Borisov wrote:
> >> if (!(BTRFS_I(inode)->flags & BTRFS_INODE_NODATASUM)) {
> >> ret = btrfs_lookup_bio_sums(inode, comp_bio,
> >> - sums);
> >> + (u8 *)sums);
> >
> > This cast (and other similar) are plain ugly. Imho we first need to get
> > the code into shape for later modification. This means postponing sha256
> > patch and instead focusing on first getting the code to use u8 where
> > relevant. Otherwise such cleanup is going to be postponed for "some time
> > in the future" will is unlikely to ever materialize.
>
> Oh, so you fix that in the next patch. Okay, disregard this then.
Exactly. There are some intermediate temporary hacks in the prep patches of
the series, but they're not persistent.
Byte,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
