On Fri, May 10, 2019 at 12:56:54PM +0000, Chris Mason wrote: > It groups together everyone using crc32c as a directory name hash (or > extref hash), so that if we ever want to add different hashes later down > the line, it's really clear what needs to change for what purpose. With > everyone calling into btrfs_crc32c directly, you have to spend more time > looking through history to figure out how to change it. > > Also, sprinkling (u32)~1 makes the code less readable imho. Fair enough, thanks for the review. Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
