[btrfs:for-kdave 5/8] fs/btrfs/inode.c:1220:3: note: in expansion of macro 'if'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-kdave
head:   6eb23136f1d35452008e6a442e152cf89e2f1d4b
commit: e0a01e7b75965e361277eff1d6fc4f4fd9fa44d5 [5/8] Btrfs: use REQ_CGROOT for worker thread submitted bios
config: i386-randconfig-x001-201918 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout e0a01e7b75965e361277eff1d6fc4f4fd9fa44d5
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from include/linux/export.h:45:0,
                    from include/linux/linkage.h:7,
                    from include/linux/kernel.h:8,
                    from fs/btrfs/inode.c:6:
   fs/btrfs/inode.c: In function 'cow_file_range_async':
   fs/btrfs/inode.c:1220:10: error: 'struct writeback_control' has no member named 'wb'
      if (wbc->wb && wbc->wb->blkcg_css) {
             ^
   include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> fs/btrfs/inode.c:1220:3: note: in expansion of macro 'if'
      if (wbc->wb && wbc->wb->blkcg_css) {
      ^~
   fs/btrfs/inode.c:1220:21: error: 'struct writeback_control' has no member named 'wb'
      if (wbc->wb && wbc->wb->blkcg_css) {
                        ^
   include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> fs/btrfs/inode.c:1220:3: note: in expansion of macro 'if'
      if (wbc->wb && wbc->wb->blkcg_css) {
      ^~
   fs/btrfs/inode.c:1220:10: error: 'struct writeback_control' has no member named 'wb'
      if (wbc->wb && wbc->wb->blkcg_css) {
             ^
   include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> fs/btrfs/inode.c:1220:3: note: in expansion of macro 'if'
      if (wbc->wb && wbc->wb->blkcg_css) {
      ^~
   fs/btrfs/inode.c:1220:21: error: 'struct writeback_control' has no member named 'wb'
      if (wbc->wb && wbc->wb->blkcg_css) {
                        ^
   include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> fs/btrfs/inode.c:1220:3: note: in expansion of macro 'if'
      if (wbc->wb && wbc->wb->blkcg_css) {
      ^~
   fs/btrfs/inode.c:1220:10: error: 'struct writeback_control' has no member named 'wb'
      if (wbc->wb && wbc->wb->blkcg_css) {
             ^
   include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> fs/btrfs/inode.c:1220:3: note: in expansion of macro 'if'
      if (wbc->wb && wbc->wb->blkcg_css) {
      ^~
   fs/btrfs/inode.c:1220:21: error: 'struct writeback_control' has no member named 'wb'
      if (wbc->wb && wbc->wb->blkcg_css) {
                        ^
   include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> fs/btrfs/inode.c:1220:3: note: in expansion of macro 'if'
      if (wbc->wb && wbc->wb->blkcg_css) {
      ^~
   fs/btrfs/inode.c:1221:15: error: 'struct writeback_control' has no member named 'wb'
       css_get(wbc->wb->blkcg_css);
                  ^~
   fs/btrfs/inode.c:1222:30: error: 'struct writeback_control' has no member named 'wb'
       async_cow->blkcg_css = wbc->wb->blkcg_css;
                                 ^~

vim +/if +1220 fs/btrfs/inode.c

  1191	
  1192	static int cow_file_range_async(struct inode *inode,
  1193					struct writeback_control *wbc,
  1194					struct page *locked_page,
  1195					u64 start, u64 end, int *page_started,
  1196					unsigned long *nr_written,
  1197					unsigned int write_flags)
  1198	{
  1199		struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
  1200		struct async_cow *async_cow;
  1201		unsigned long nr_pages;
  1202		u64 cur_end;
  1203	
  1204		clear_extent_bit(&BTRFS_I(inode)->io_tree, start, end, EXTENT_LOCKED,
  1205				 1, 0, NULL);
  1206		while (start < end) {
  1207			async_cow = kmalloc(sizeof(*async_cow), GFP_NOFS);
  1208			BUG_ON(!async_cow); /* -ENOMEM */
  1209			/*
  1210			 * igrab is called higher up in the call chain, take only the
  1211			 * lightweight reference for the callback lifetime
  1212			 */
  1213			ihold(inode);
  1214			async_cow->inode = inode;
  1215			async_cow->fs_info = fs_info;
  1216			async_cow->locked_page = locked_page;
  1217			async_cow->start = start;
  1218			async_cow->write_flags = write_flags;
  1219	
> 1220			if (wbc->wb && wbc->wb->blkcg_css) {
  1221				css_get(wbc->wb->blkcg_css);
  1222				async_cow->blkcg_css = wbc->wb->blkcg_css;
  1223			} else {
  1224				async_cow->blkcg_css = NULL;
  1225			}
  1226	
  1227			if (BTRFS_I(inode)->flags & BTRFS_INODE_NOCOMPRESS &&
  1228			    !btrfs_test_opt(fs_info, FORCE_COMPRESS))
  1229				cur_end = end;
  1230			else
  1231				cur_end = min(end, start + SZ_512K - 1);
  1232	
  1233			async_cow->end = cur_end;
  1234			INIT_LIST_HEAD(&async_cow->extents);
  1235	
  1236			btrfs_init_work(&async_cow->work,
  1237					btrfs_delalloc_helper,
  1238					async_cow_start, async_cow_submit,
  1239					async_cow_free);
  1240	
  1241			nr_pages = (cur_end - start + PAGE_SIZE) >>
  1242				PAGE_SHIFT;
  1243			atomic_add(nr_pages, &fs_info->async_delalloc_pages);
  1244	
  1245			btrfs_queue_work(fs_info->delalloc_workers, &async_cow->work);
  1246	
  1247			*nr_written += nr_pages;
  1248			start = cur_end + 1;
  1249		}
  1250		*page_started = 1;
  1251		return 0;
  1252	}
  1253	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux