Re: [PATCH] btrfs: don't double unlock on error in btrfs_punch_hole

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 03, 2019 at 03:31:33PM +0000, Rik van Riel wrote:
> On Fri, 2019-05-03 at 16:25 +0100, Filipe Manana wrote:
> > On Fri, May 3, 2019 at 4:21 PM Josef Bacik <josef@xxxxxxxxxxxxxx>
> > wrote:
> > > If we have an error writing out a delalloc range in
> > > btrfs_punch_hole_lock_range we'll unlock the inode and then goto
> > > out_only_mutex, where we will again unlock the inode.  This is bad,
> > > don't do this.
> > > 
> > > Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
> > 
> > Reviewed-by: Filipe Manana <fdmanana@xxxxxxxx>
> > 
> > Looks good, I introduced the double unlock accidentally.
> 
> Does the patch need a Fixes: tag so the -stable
> people know how far to backport it?

I add the tags.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux