On Tue, Apr 16, 2019 at 01:16:37PM +0800, Qu Wenruo wrote: > This function always return 0, and the only use case of @ret is to > output warning message for discard failure, which doesn't cause anything > wrong to the fs even discarding failed. > > There is no need to make it return int. Same comment as https://patchwork.kernel.org/patch/10901977/ , check the whole callgraph of the function before making it return void.
