On Wed, Apr 3, 2019 at 8:48 PM Jeff Mahoney <jeffm@xxxxxxxx> wrote: > > My team is always interested in images of broken file systems. This is > how --repair evolves. Images with failed --repair operations are still > valuable. That's the first step most users take and why wouldn't they? > If --repair is misbehaving, the end result shouldn't be "I hope you > have backups." Ok well there's a lot of that still happening. So what switches should users use for images these days? It's not obvious whether there's extent tree corruption so are they best off always using -w? And I know Qu doesn't like images with either -s or -ss, and I don't think users care which one they use, but it's not reasonable that they supply images that don't have file and dir names scrubbed. And then where and how should they submit the images? I haven't taken an image yet but do have a file system that was working fine before using btrfs-progs 4.19.1 with --clear-space-cache v1 that definitely corrupted the extent tree. I have 0% confidence in --repair or --init-extent-tree fixing it so I haven't tried it yet, and it's a backup so it doesn't really matter. I did file a bug. https://bugzilla.kernel.org/show_bug.cgi?id=202717 -- Chris Murphy
