Re: [PATCH 1/2] btrfs: tree-checker: Remove comprehensive root owner check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 04, 2019 at 09:23:11AM +0300, Nikolay Borisov wrote:
> 
> 
> On 4.04.19 г. 6:47 ч., Qu Wenruo wrote:
> > Commit 1ba98d086fe3 ("Btrfs: detect corruption when non-root leaf has
> > zero item") introduced comprehensive root owner checker.
> > 
> > However it's pretty expensive tree search to locate the owner root,
> > especially when it get reused by mandatory read and write time
> > tree-checker.
> > 
> > This patch will remove that check, and completely rely on owner based
> > empty leaf check, which is much faster and still works fine for most
> > case.
> > 
> > And since we skip the old root owner check, now write time tree check
> > can be merged with btrfs_check_leaf_full().
> > 
> > Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>
> 
> This patch was sent yesterday, now it's sent again with no material
> changes whatsoever? What's the point?

The core change is the same, but there are removed hunks compared to v1.
We've discussed that yesterday and Qu did it right.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux