Re: [PATCH 3/4 RESEND] btrfs: open code btrfs_set_prop in inherit_prop

Anand Jain <anand.jain@xxxxxxxxxx> · Wed, 3 Apr 2019 08:42:01 +0800






On 3/4/19 7:24 AM, David Sterba wrote:
On Tue, Apr 02, 2019 at 04:35:12PM +0300, Nikolay Borisov wrote:
@@ -367,20 +367,35 @@ static int inherit_props(struct btrfs_trans_handle *trans,
  		if (!value)
  			continue;
  
+		/* may be removed */

This comment brings no value. Either explain *why* it can be removed or
remove it altogether.

Comment replaced by

                  /*
                   * This is not strictly necessary as the property should be
                   * valid, but in case it isn't, don't propagate it futher.
                   */

I'd keep it the because that's what the direct opencoding transformation would
do. If we want to remove it, then the reasoning should be provided.

  Agreed with the reasoning.

Thanks, Anand






