Re: [PATCH 1/2] btrfs: Make btrfs_(set|clear)_header_flag return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 19.03.19 г. 8:04 ч., Qu Wenruo wrote:
> From the introduce of btrfs_(set|clear)_header_flag, there is no usage
> of its return value.
> 
> So just make it return void.
> 
> Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>

Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>


> ---
>  fs/btrfs/ctree.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index b3642367a595..c03852d1aa34 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -2163,18 +2163,16 @@ static inline int btrfs_header_flag(const struct extent_buffer *eb, u64 flag)
>  	return (btrfs_header_flags(eb) & flag) == flag;
>  }
>  
> -static inline int btrfs_set_header_flag(struct extent_buffer *eb, u64 flag)
> +static inline void btrfs_set_header_flag(struct extent_buffer *eb, u64 flag)
>  {
>  	u64 flags = btrfs_header_flags(eb);
>  	btrfs_set_header_flags(eb, flags | flag);
> -	return (flags & flag) == flag;
>  }
>  
> -static inline int btrfs_clear_header_flag(struct extent_buffer *eb, u64 flag)
> +static inline void btrfs_clear_header_flag(struct extent_buffer *eb, u64 flag)
>  {
>  	u64 flags = btrfs_header_flags(eb);
>  	btrfs_set_header_flags(eb, flags & ~flag);
> -	return (flags & flag) == flag;
>  }
>  
>  static inline int btrfs_header_backref_rev(const struct extent_buffer *eb)
> 



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux