On 3/14/19 4:57 PM, Nikolay Borisov wrote:
On 14.03.19 г. 7:05 ч., Anand Jain wrote:
When an inode inherits property from its parent, we call btrfs_set_prop().
btrfs_set_prop() does an elaborate checks, which is not required in the
context of inheriting a property. Instead just open-code only the required
items from btrfs_set_prop() and then call btrfs_setxattr() directly. So
now the only user of btrfs_set_prop() is gone, (except for the wraper
function btrfs_set_prop_trans()).
Um, no:
git grep -P '(?<!__)btrfs_set_prop' fs/btrfs/
fs/btrfs/ioctl.c: ret = btrfs_set_prop(inode, "btrfs.compression", NULL, 0, 0);
fs/btrfs/ioctl.c: ret = btrfs_set_prop(inode, "btrfs.compression",
fs/btrfs/ioctl.c: ret = btrfs_set_prop(inode, "btrfs.compression", NULL, 0, 0);
fs/btrfs/props.c:int btrfs_set_prop(struct inode *inode,
fs/btrfs/props.h:int btrfs_set_prop(struct inode *inode,
fs/btrfs/xattr.c: return btrfs_set_prop(inode, name, value, size, flags);
Rebase the patch on misc-next and remove the last sentence
since it's factually wrong.
Oh. This is based on misc-5.2.
Oops I should have mentioned.
Thanks. Anand
