On Fri, Mar 01, 2019 at 12:34:52PM +0800, Anand Jain wrote: > The main motivation is to avoid NULL for the trans argument reaching > btrfs_set_xattr(). This patch does the following in btrfs_set_acl(). > Create transaction and handle the inode changes update, (copies code > from btrfs_setxattr() as in the original, which needs a fix). > Rename __btrfs_set_acl to do_set_acl as this is a helper function. > Fix a c-code style, expand function declaration to max length 80 char. You don't need to mention fixing the coding style unless it's the sole purpose of the patch. > Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx> > --- > v5: change log update. Use BUG_ON instead of ASSERT. > v4: born > fs/btrfs/acl.c | 36 ++++++++++++++++++++++++++---------- > 1 file changed, 26 insertions(+), 10 deletions(-) > > -int btrfs_init_acl(struct btrfs_trans_handle *trans, > - struct inode *inode, struct inode *dir) > +int btrfs_init_acl(struct btrfs_trans_handle *trans, struct inode *inode, > + struct inode *dir) Please don't do such drive-by changes, there's no difference but one has still make sure there is none and that it's not an accidental edit. It's ok if you rename or move a function to fix the indentation but otherwise I have to review it and then undo it.
