Re: [PATCH] btrfs: remove WARN_ON() in log_dir_items

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 06, 2019 at 05:13:04PM -0500, Josef Bacik wrote:
> When Filipe added the recursive directory logging stuff he specifically
> didn't take the directory i_mutex for the children directories that we
> need to log because of lockdep.  This is generally fine, but can lead to
> this WARN_ON() tripping if we happen to run delayed deletion's in
> between our first search and our second search of dir_item/dir_indexes
> for this directory.  We expect this to happen, so the WARN_ON() isn't
> necessary.  Drop the WARN_ON() and add a comment so we know why this
> case can happen.
> 
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>

Added to misc-next, thanks.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux