Re: [PATCH] btrfs: qgroup: Don't scan leaf if we're modifying reloc tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 13, 2018 at 01:48:56PM +0800, Qu Wenruo wrote:
> Since reloc tree doesn't contribute to qgroup numbers, just skip them.
> 
> This should catch the final leakage of unnecessary data refs for qgroup.
> The 4G data 16 snapshots test should explain it pretty well:
> 
>              | delayed subtree | refactor delayed ref | this patch (*)
> ---------------------------------------------------------------------
> relocated    |           22653 |                22673 |         22744
> qgroup dirty |          122792 |                48360 |            70
> time         |          24.494 |               11.606 |         3.944
> 
> *: Needs to be applied upon delayed subtree scan and delayed ref
> refactor patchsets.
> 
> Finally, we're at the stage where qgroup + metadata balance cost no
> obvious overhead.

I don't see this patch in any of the development branches but given the
above I think it should be there. It's possible that I have missed an
update, sorry, please let me know the current status.

The dependencies have been merged for 5.1 so I could still queue it, and
the performance improvement is quite desired.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux