Re: [RFC PATCH] btrfs: Remove __extent_readpages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 11, 2019 at 09:46:10AM +0200, Nikolay Borisov wrote:
> >      issued rwts: total=2621440,0,0,0 short=0,0,0,0 dropped=0,0,0,0
> >      latency   : target=0, window=0, percentile=100.00%, depth=1
> > 
> > Run status group 0 (all jobs):
> >    READ: bw=353MiB/s (370MB/s), 353MiB/s-353MiB/s (370MB/s-370MB/s), io=10.0GiB (10.7GB), run=29008-29008msec
> > 
> > Clearly both bandwidth and iops are worse. However I'm puzzled as to why this is 
> > the case, given that I don't see how this patch affects the submission of 
> > readahead io. 
> > 
> >  fs/btrfs/extent_io.c | 63 +++++++++++++-------------------------------
> >  1 file changed, 19 insertions(+), 44 deletions(-)
> 
> Revisiting the patch and the results IMHO it shouldn't be RFC and is
> ready for merging.

I almost missed it. Please resend it without RFC, update the changelog
with anything relevant that came out of the discussion and fix typos and
coding style. The subject should describe what's the core of the change,
removing __extent_readpages is IMHO just a side effect. Thanks.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux