On 22/02/2019 15:55, David Sterba wrote: >> >> - return csum_tree_block(fs_info, eb, 0); >> + if (WARN_ON(csum_tree_block(eb, result))) > > I think the warn should go to csum_tree_block when the mapping function > returns 1, there's even a comment explaining why it can't normally > happen. The reason for the warning in csum_dirty_buffer is not very > clear from the context. > > Otherwise ok, the verify or write semantics of a function that (by name) > only calculates checksum is confusing. Thanks. Sure. Would it make sense to split this into two patches? -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
