On 02/01/2019 18:43, Nikolay Borisov wrote: > > > On 2.01.19 г. 19:05 ч., David Sterba wrote: >> This is repeating code and could be simplified ... to the original code. > > It does and this is intentional. What I've strived to do is make the > idea of the code obvious and not try to reduce the total line of code. > It is a massive improvement given the code which modifies extent_end > triggers only in case ret is > 0. I discussed this with Johannes and he > agreed with my assessment. > >> I'm not sure this patch is an improvement. I think it really helps when trying to understand the code. This is why the patch was created in the first place, I asked Nik about something and we went over the code together. In the end it's your call, obviously. Byte, Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
