Re: [PATCH 0/3] Cleanups around btrfs_get_extent_fiemap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 12, 2018 at 09:42:31AM +0200, Nikolay Borisov wrote:
> Following a conversation with Johaness this is what fell out. Turns out the
> signature of btrfs_get_extent_fiemap is needlessly complext. So the first patch 
> fixes it by removing the unnecessary arguments. Patch 2 is a bit of a "catch-all"
> mainly renaming variables, thus helping recognise what the code does and
> refreshing comments and removing one extra if. Finally, patch 3 removes an
> assignment making it (at least to me) more clear what context a particular
> variable is used in.
> 
> This has survived multiple xfstest runs. 
> 
> Nikolay Borisov (3):
>   btrfs: Remove unused arguments from btrfs_get_extent_fiemap
>   btrfs: Refactor btrfs_get_extent_fiemap
>   btrfs: Remove redundant assignment

1-3 added to misc-next, thanks. I did a few more adjustments to comments
in patch 2/3.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux