Re: [PATCH 0/4] Misc cleanups of btrfs_get_extent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 17, 2018 at 10:35:58AM +0200, Nikolay Borisov wrote:
> Here is a series that hopefully makes the code a bit more obvious. First patch 
> gives a variable a more appropraite name, since it's going to be used only for 
> holding an extent type and not the type of a found item. 
> 
> Patch 2 simply consolidated separate 'if' statements that check the retval of
> the same function into a single 'if() {} else if () {}' statement. IMO this is 
> cleaner.
> 
> Patch 3 massages the abhorrent code that deals with btrfs_lookup_file_extent
> retval. It groups everything in a coherent 'if() {} else if () {} else {}' 
> construct and now it's obvious under what conditions specific code is executed. 
> 
> Finally, Patch 4 removes the not_found_em labelin the same function.
> 
> Nikolay Borisov (4):
>   btrfs: Rename found_type to extent_type
>   btrfs: Consolidate retval checking of core btree functions
>   btrfs: Refactor retval handling of btrfs_lookup_file_extent in
>     btrfs_get_extent
>   btrfs: Remove not_found_em label from btrfs_get_extent

1, 2 and 4 now added to for-next, thanks.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux