On 2018/12/26 下午1:37, Kangjie Lu wrote: > In case sysfs_create_group fails, let's check its return value and > issues an error message. > > Signed-off-by: Kangjie Lu <kjlu@xxxxxxx> > --- > fs/btrfs/sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c > index 3717c864ba23..24ef416e700b 100644 > --- a/fs/btrfs/sysfs.c > +++ b/fs/btrfs/sysfs.c > @@ -889,6 +889,8 @@ void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info, > */ > sysfs_remove_group(fsid_kobj, &btrfs_feature_attr_group); > ret = sysfs_create_group(fsid_kobj, &btrfs_feature_attr_group); > + if (ret) > + btrfs_err(fs_info, "failed to create btrfs_feature_attr_group.\n"); Forgot to mention, for btrfs_* infrastructure, no need for the ending '\n'. Despite that, looks good. Reviewed-by: Qu Wenruo <wqu@xxxxxxxx> Thanks, Qu > } > > static int btrfs_init_debugfs(void) >
Attachment:
signature.asc
Description: OpenPGP digital signature
