Re: [PATCH v2 2/8] btrfs: extent-tree: Open-code process_func in __btrfs_mod_ref

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2018/12/12 下午5:40, Johannes Thumshirn wrote:
> On 12/12/2018 08:30, Qu Wenruo wrote:
>> The process_func is never a function hook used anywhere else.
>>
> 
> Hmm this sounds odd, maybe something like:
> 
> The process_func function pointer is local to __btrfs_mod_ref() and
> points to either btrfs_inc_extent_ref() or btrfs_free_extent().

Much better, thanks for the better words!

I'll reword these commits.

Thanks,
Qu

> 
>> Open code it to make later delayed ref refactor easier, so we can
>> refactor btrfs_inc_extent_ref() and btrfs_free_extent() in different
>> patches.
> 
> Otherwise:
> Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> 

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux