On 05/12/2018 13:28, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx>
Can you explain why we can't use th dax_iomap_rw() interface like XFS or
EXT4?
[...]
> +static ssize_t em_dax_rw(struct inode *inode, struct extent_map *em, u64 pos,
> + u64 len, struct iov_iter *iter)
> +{
> + struct dax_device *dax_dev = fs_dax_get_by_bdev(em->bdev);
> + ssize_t map_len;
> + pgoff_t blk_pg;
> + void *kaddr;
> + sector_t blk_start;
> + unsigned offset = pos & (PAGE_SIZE - 1);
Nit: unsigned offset = offset_in_page(pos);
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
