Re: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()
From: David Sterba <dsterba@xxxxxxx>
Date: Wed, 28 Nov 2018 16:41:51 +0100
Cc: David Sterba <dsterba@xxxxxxxx>, Linux BTRFS Mailinglist <linux-btrfs@xxxxxxxxxxxxxxx>
In-reply-to: <20181128085456.5702-3-jthumshirn@suse.de>
Mail-followup-to: dsterba@xxxxxxx, Johannes Thumshirn <jthumshirn@xxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Linux BTRFS Mailinglist <linux-btrfs@xxxxxxxxxxxxxxx>
References: <20181128085456.5702-1-jthumshirn@suse.de> <20181128085456.5702-3-jthumshirn@suse.de>
Reply-to: dsterba@xxxxxxx
User-agent: Mutt/1.5.23.1 (2014-03-12)

On Wed, Nov 28, 2018 at 09:54:55AM +0100, Johannes Thumshirn wrote:
> In map_private_extent_buffer() use offset_in_page() to initialize
> 'start_offset' instead of open-coding it.

Can you please fix all instances where it's opencoded? Grepping for
'PAGE_SIZE - 1' finds a number of them. Thanks.

Follow-Ups:
- Re: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()
  - From: Johannes Thumshirn

References:
- [PATCH v2 0/3] Misc cosmetic changes for map_private_extent_buffer
  - From: Johannes Thumshirn
- [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()
  - From: Johannes Thumshirn

Prev by Date: Re: [PATCH 1/9] btrfs: switch BTRFS_FS_STATE_* to enums
Next by Date: Re: [PATCH v2 0/3] Misc cosmetic changes for map_private_extent_buffer
Previous by thread: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()
Next by thread: Re: [PATCH v2 2/3] btrfs: use offset_in_page for start_offset in map_private_extent_buffer()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]