Re: [PATCH] Fix typos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 28.11.18 г. 15:24 ч., Brendan Hide wrote:
> 
> 
> On 11/28/18 1:23 PM, Nikolay Borisov wrote:
>>
>>
>> On 28.11.18 г. 13:05 ч., Andrea Gelmini wrote:
>>> Signed-off-by: Andrea Gelmini <andrea.gelmini@xxxxxxxxx>
>>> ---
> 
> <snip>
> 
>>>
>>> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
>>> index bab2f1983c07..babbd75d91d2 100644
>>> --- a/fs/btrfs/inode.c
>>> +++ b/fs/btrfs/inode.c
>>> @@ -104,7 +104,7 @@ static void __endio_write_update_ordered(struct
>>> inode *inode,
>>>     /*
>>>    * Cleanup all submitted ordered extents in specified range to
>>> handle errors
>>> - * from the fill_dellaloc() callback.
>>> + * from the fill_delalloc() callback.
>>
>> This is a pure whitespace fix which is generally frowned upon. What you
>> can do though, is replace 'fill_delalloc callback' with
>> 'btrfs_run_delalloc_range' since the callback is gone already.
>>
>>>    *
>>>    * NOTE: caller must ensure that when an error happens, it can not
>>> call
>>>    * extent_clear_unlock_delalloc() to clear both the bits
>>> EXTENT_DO_ACCOUNTING
>>> @@ -1831,7 +1831,7 @@ void btrfs_clear_delalloc_extent(struct inode
>>> *vfs_inode,
>>
>> <snip>
>>
>>> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
>>> index 410c7e007ba8..d7b6c2b09a0c 100644
>>> --- a/fs/btrfs/ioctl.c
>>> +++ b/fs/btrfs/ioctl.c
>>> @@ -892,7 +892,7 @@ static int create_snapshot(struct btrfs_root
>>> *root, struct inode *dir,
>>>    *  7. If we were asked to remove a directory and victim isn't one
>>> - ENOTDIR.
>>>    *  8. If we were asked to remove a non-directory and victim isn't
>>> one - EISDIR.
>>>    *  9. We can't remove a root or mountpoint.
>>> - * 10. We don't allow removal of NFS sillyrenamed files; it's
>>> handled by
>>> + * 10. We don't allow removal of NFS silly renamed files; it's
>>> handled by
>>>    *     nfs_async_unlink().
>>>    */
>>>   @@ -3522,7 +3522,7 @@ static int btrfs_extent_same_range(struct
>>> inode *src, u64 loff, u64 olen,
>>>                              false);
>>>       /*
>>>        * If one of the inodes has dirty pages in the respective range or
>>> -     * ordered extents, we need to flush dellaloc and wait for all
>>> ordered
>>> +     * ordered extents, we need to flush delalloc and wait for all
>>> ordered
>>
>> Just whitespace fix, drop it.
>>
>> <snip>
>>
> 
> If the spelling is changed, surely that is not a whitespace fix?

My bad, I missed it the first time.

> 



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux