Re: [PATCH] btrfs: adjust order of unlocks in do_trimming()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 28.11.18 г. 5:21 ч., Su Yue wrote:
> In function do_trimming(), block_group->lock should be unlocked first.
> 
> Fixes: 7fe1e6415026 ("Btrfs: rewrite btrfs_trim_block_group()")
> Signed-off-by: Su Yue <suy.fnst@xxxxxxxxxxxxxx>

Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>

> ---
>  fs/btrfs/free-space-cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index 4ba0aedc878b..3731fa92df56 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> @@ -3149,8 +3149,8 @@ static int do_trimming(struct btrfs_block_group_cache *block_group,
>  			space_info->bytes_readonly += reserved_bytes;
>  		block_group->reserved -= reserved_bytes;
>  		space_info->bytes_reserved -= reserved_bytes;
> -		spin_unlock(&space_info->lock);
>  		spin_unlock(&block_group->lock);
> +		spin_unlock(&space_info->lock);
>  	}
>  
>  	return ret;
> 



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux