On 27.11.18 г. 18:00 ч., Johannes Thumshirn wrote:
> In map_private_extent_buffer() the 'offset' variable is initialized to a
> page aligned version of the 'start' parameter.
>
> But later on it is overwritten with either the offset from the extent
> buffer's start or 0.
>
> So get rid of the initial initialization.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
You know, the fastest/most clean code is the one which is deleted so :
Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>
> ---
> fs/btrfs/extent_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 582b4b1c41e0..7aafdec49dc3 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -5380,7 +5380,7 @@ int map_private_extent_buffer(const struct extent_buffer *eb,
> char **map, unsigned long *map_start,
> unsigned long *map_len)
> {
> - size_t offset = start & (PAGE_SIZE - 1);
> + size_t offset;
> char *kaddr;
> struct page *p;
> size_t start_offset = eb->start & ((u64)PAGE_SIZE - 1);
>
