On 2018/9/21 下午3:33, Nikolay Borisov wrote:
>
>
> On 21.09.2018 10:20, Qu Wenruo wrote:
>> Commit 581c1760415c ("btrfs: Validate child tree block's level and first
>> key") has made tree block level check mandatory.
>>
>> So if tree block level doesn't match, we won't get a valid extent
>> buffer.
>> The extra WARN_ON() check can be removed completely.
>>
>> Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>
>> ---
>> Changelog:
>> v2:
>> Added tags.
>
> Nope you didn't :)
Face palm, only added in formatted patch, and just re-formatted patch again.
Anyway, David could handle it.
Thanks,
Qu
>
>> ---
>> fs/btrfs/relocation.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
>> index 94aa148ccde6..a554e7861b6e 100644
>> --- a/fs/btrfs/relocation.c
>> +++ b/fs/btrfs/relocation.c
>> @@ -2911,7 +2911,6 @@ static int get_tree_block_key(struct btrfs_fs_info *fs_info,
>> free_extent_buffer(eb);
>> return -EIO;
>> }
>> - WARN_ON(btrfs_header_level(eb) != block->level);
>> if (block->level == 0)
>> btrfs_item_key_to_cpu(eb, &block->key, 0);
>> else
>>
