On Wed, Sep 19, 2018 at 10:02:16PM -0700, Omar Sandoval wrote: > From: Omar Sandoval <osandov@xxxxxx> > > The Btrfs swap code is going to need it, so give it a btrfs_ prefix and > make it non-static. > > Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx> > Signed-off-by: Omar Sandoval <osandov@xxxxxx> > --- > fs/btrfs/volumes.c | 29 ++++++++++++++++++----------- > fs/btrfs/volumes.h | 2 ++ > 2 files changed, 20 insertions(+), 11 deletions(-) > > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c > index a2761395ed22..fe66b635c023 100644 > --- a/fs/btrfs/volumes.c > +++ b/fs/btrfs/volumes.c > @@ -2714,8 +2714,15 @@ static int btrfs_del_sys_chunk(struct btrfs_fs_info *fs_info, u64 chunk_offset) > return ret; > } > > -static struct extent_map *get_chunk_map(struct btrfs_fs_info *fs_info, > - u64 logical, u64 length) > +/** Minor nit, I'll fix that eventually: the /** is for kernel doc but as the function is internal to btrfs and there's no documentation generated from that, it's better to use plain /* . The parameter formatting according to the kernel doc documentation is fine but does not strictly need to conform as long as it's human readable. Otherwise patch is ok.
