Currently btrfs_find_device_by_path, btrfs_find_device_missing_or_by_path and
btrfs_find_device_by_devspec are called in a chain and they all return an
integer value to signal error and at the same time use one of their parameters
as an output. This patch set refactors those functions starting from the
bottom, gradually making them return a pointer to btrfs_device. This is
sufficient to convey an error when it occurs as well as return the actual
device we are looking for. One added benefit is that the ioctl-specific positive
return value BTRFS_ERROR_DEV_MISSING_NOT_FOUND is now returned from
btrfs_rm_device rather than from some internal function.
Additionally I'll be sending a patch to progs, adding a test ensuring that
BTRFS_ERROR_MISSING_NOT_FOUND is returned appropriately.
This survived both my btrfs-progs test as well as xfstest run. No functional
changes.
Nikolay Borisov (3):
btrfs: Make btrfs_find_device_by_path return struct btrfs_device
btrfs: Make btrfs_find_device_missing_or_by_path return directly a
device
btrfs: Make btrfs_find_device_by_devspec return btrfs_device directly
fs/btrfs/dev-replace.c | 8 ++---
fs/btrfs/volumes.c | 73 ++++++++++++++++++++++--------------------
fs/btrfs/volumes.h | 9 ++----
3 files changed, 45 insertions(+), 45 deletions(-)
--
2.17.1
