Re: [PATCH 0/2] btrfs-progs: task: add prefn() to task_info and simplify task_start()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> Sent: Wednesday, August 22, 2018 at 3:38 AM
> From: "Nikolay Borisov" <nborisov@xxxxxxxx>
> To: damenly.su@xxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
> Cc: "Su Yue" <suy.fnst@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH 0/2] btrfs-progs: task: add prefn() to task_info and simplify task_start()
>
> 
> 
> On 21.08.2018 21:23, damenly.su@xxxxxxxxx wrote:
> > From: Su Yue <suy.fnst@xxxxxxxxxxxxxx>
> > 
> > This patchset is a prepare work for further process of check.
> > 
> > patch[1] adds prefn() to task_info and call it before pthread_create().
> > 
> > patch[2] moves time and count initializations into the new init_ctx(),
> > assign it to prefun(). Remove arguments start_time and item_count.
> > 
> 
> The patches look good albeit being isolated it's hard to see their
> merit. I'd advise to submit them alongside whatever larger refactoring
> you have in mind.
> 
OK, it will be submitted together with others.

Thanks,
Su

> > 
> > Su Yue (2):
> >   btrfs-progs: task: add prefn() into struct task_info
> >   btrfs-progs: task: add init_ctx and clean up arguments of task_start()
> > 
> >  check/main.c   | 27 +++++++++++++++++++--------
> >  convert/main.c |  6 +++---
> >  task-utils.c   | 17 +++++++++--------
> >  task-utils.h   |  5 +++--
> >  4 files changed, 34 insertions(+), 21 deletions(-)
> > 
> 



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux