Re: [PATCH 1/2] btrfstune: Remove fs_info arg from change_device_uuid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2018/8/20 下午9:28, Nikolay Borisov wrote:
> This function already takes an extent buffer that contains a reference
> to the fs_info. Use that and reduce argument count. No functional
> changes.
> 
> Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>

Reviewed-by: Qu Wenruo <wqu@xxxxxxxx>

Thanks,
Qu

> ---
>  btrfstune.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/btrfstune.c b/btrfstune.c
> index 889b931c55d8..723317a00f3a 100644
> --- a/btrfstune.c
> +++ b/btrfstune.c
> @@ -179,10 +179,10 @@ static int change_extents_uuid(struct btrfs_fs_info *fs_info)
>  	return ret;
>  }
>  
> -static int change_device_uuid(struct btrfs_fs_info *fs_info, struct extent_buffer *eb,
> -			      int slot)
> +static int change_device_uuid(struct extent_buffer *eb, int slot)
>  {
>  	struct btrfs_dev_item *di;
> +	struct btrfs_fs_info *fs_info = eb->fs_info;
>  	int ret = 0;
>  
>  	di = btrfs_item_ptr(eb, slot, struct btrfs_dev_item);
> @@ -217,7 +217,7 @@ static int change_devices_uuid(struct btrfs_fs_info *fs_info)
>  		if (key.type != BTRFS_DEV_ITEM_KEY ||
>  		    key.objectid != BTRFS_DEV_ITEMS_OBJECTID)
>  			goto next;
> -		ret = change_device_uuid(fs_info, path.nodes[0], path.slots[0]);
> +		ret = change_device_uuid(path.nodes[0], path.slots[0]);
>  		if (ret < 0)
>  			goto out;
>  next:
> 



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux