Re: [PATCH] Btrfs: clean up scrub is_dev_replace parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 14, 2018 at 11:09:52AM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@xxxxxx>
> 
> struct scrub_ctx has an ->is_dev_replace member, so there's no point in
> passing around is_dev_replace where sctx is available.
> 
> Signed-off-by: Omar Sandoval <osandov@xxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>

There's still id_dev_replace passed to scrub_workers_get but it's a
small and static helper. I don't think it's necessary to drop that
parameter too, the fs_info or scrub context would have to be adjusted
anyway.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux