On 2018/8/7 23:25, David Sterba wrote: > On Mon, Aug 06, 2018 at 10:52:58AM +0800, zhong jiang wrote: >> The err is not modified after initalization, So just remove it and make >> the function to be void function. >> >> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> >> --- >> v1->v2: >> - Merge v1 series into a patch to void same changelog. > Please do one patch per function. If the change follows the same logic, > it's not a problem to use the same changelog, but the patch should be > revieweable and not doing unrelated things. > > If the function prototype or return values is changed it's easier from > the reviewer's perspective to focus on just one function and the > surrounding code. Even if it looks straightforward to you to merge them > together. > > When the return value changes from int -> void, it's necessary to check > wheter any of the callees is not hiding a BUG_ON that should be really > turned into proper error handling in the caller. In that case the return > type should stay and error handling added. > > After a brief look I think all functions are safe here, but that's > something that should be mentioned in the changelog. Please update the > patches and resend. Thanks. > > . > I will repost the patches with detailed changlog. Thank you for explaination. Thanks zhong jiang -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
