Re: [PATCH 0/3] Remove uneeded variable "err"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On  5.08.2018 18:02, zhong jiang wrote:
> 
> zhong jiang (3):
>   fs/btrfs/disk-io: Remove unneeded variable "err"
>   fs/btrfs/extent-tree: remove redudant variable "err"
>   fs/btrfs/tree-log: remove the unneeded variable "err"
> 
>  fs/btrfs/disk-io.c     | 12 ++++--------
>  fs/btrfs/extent-tree.c |  6 ++----
>  fs/btrfs/tree-log.c    |  5 +----
>  fs/btrfs/tree-log.h    |  2 +-
>  4 files changed, 8 insertions(+), 17 deletions(-)
> 


NAK on the whole series on the basis of using a bulk commit message
which doesn't really describe the changes of each individual commit. If
you want those changes to eventually be merged resubmit the series with
individual reasoning for every commit.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux