On Fri, Jul 20, 2018 at 07:37:46PM +0300, Nikolay Borisov wrote: >Here are a bunch of patches which cleanup extraneous fs_info parameters to >function which already take a structure that holds a reference to the fs_info. > >Except for patches 4 and 5, everything else is correct - due to those functions >always taking a transaction. 4 and 5 in turn reference the fs_info from >struct btrfs_device. Inspecting the callers I managed to convince myself that >those function are always called with well-formed btrfs_device i.e one which >has its fs_info member initialised. Reviewers might want to pay extra >attention to that but otherwise they are trivial. > >Nikolay Borisov (7): > btrfs: Remove fs_info argument from btrfs_add_dev_item > btrfs: Remove fs_info from btrfs_rm_dev_replace_remove_srcdev > btrfs: remove fs_info argument from update_dev_stat_item > btrfs: Remove fs_info from btrfs_assign_next_active_device > btrfs: Remove fs_info from btrfs_destroy_dev_replace_tgtdev > btrfs: Remove fs_info form btrfs_free_chunk > btrfs: Remove fs_info from btrfs_finish_chunk_alloc The series looks good to me. Reviewed-by: Lu Fengqi <lufq.fnst@xxxxxxxxxxxxxx> -- Thanks, Lu > > fs/btrfs/dev-replace.c | 10 +++++----- > fs/btrfs/extent-tree.c | 5 ++--- > fs/btrfs/volumes.c | 49 +++++++++++++++++++++++-------------------------- > fs/btrfs/volumes.h | 16 ++++++---------- > 4 files changed, 36 insertions(+), 44 deletions(-) > >-- >2.7.4 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
