Re: [PATCH] btrfs-progs: check: Fix wrong error message in case of corrupted extent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 05, 2018 at 02:39:10PM +0300, Nikolay Borisov wrote:
> When btrfs check detects a freespace tree extent which ends beyond the
> blockgroup containing it a misleading error messages is printed. For
> example if we have the following extent in the freespace tree:
> 
>     item 5 key (30408704 FREE_SPACE_INFO 1073741824) itemoff 16259 itemsize 8
>             free space info extent count 3 flags 0
>     item 6 key (30425088 FREE_SPACE_EXTENT 49152) itemoff 16259 itemsize 0
>             free space extent
>     item 7 key (30507008 FREE_SPACE_EXTENT 65536) itemoff 16259 itemsize 0
>             free space extent
>     item 8 key (30654464 FREE_SPACE_EXTENT 14524648038063310901) itemoff 16259 itemsize 0
> 
> Clearly the last extent is corrupted so we should print something
> along the lines of:
> 
> free space extent ends at 14524648038063310901, beyond end of block group 30408704-1104150528
> 
> Instead currently this is printed:
> 
> free space extent ends at 30654464, beyond end of block group 30408704-1104150528
> 
> So instead of printing the actual erroneous end, we print the beginning
> of the extent. Fix this by printing the actual corrupted end.
> 
> Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux