Re: [PATCH] Btrfs: make sure there is always room for generation number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



code inspection. If I understand it correctly, we are off by 4 bytes
because CRC is 32 bits and generation is 64 bits. But this bug might
never hit in practice.

thanks,

-Zhihui

On Wed, Jul 4, 2018 at 11:21 AM, David Sterba <dsterba@xxxxxxx> wrote:
> On Mon, Jul 02, 2018 at 08:00:54PM -0400, Zhihui Zhang wrote:
>> io_ctl_set_generation() assumes that the generation number shares
>> the same page with inline CRCs. Let's make sure this is always true.
>>
>> Signed-off-by: Zhihui Zhang <zzhsuny@xxxxxxxxx>
>
> Reviewed-by: David Sterba <dsterba@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux