On 2.07.2018 11:47, Qu Wenruo wrote:
>
>
> On 2018年07月02日 16:37, Nikolay Borisov wrote:
>>
>>
>> On 2.07.2018 11:34, Qu Wenruo wrote:
>>> + if (hweight64(flags & BTRFS_BLOCK_GROUP_PROFILE_MASK) > 1) {
>>> + block_group_err(fs_info, leaf, slot,
>>> +"invalid profile flags, have 0x%llx (%lu bits set) expect no more than 1 bit set",
>>> + flags & BTRFS_BLOCK_GROUP_PROFILE_MASK,
>>> + hweight64(flags & BTRFS_BLOCK_GROUP_PROFILE_MASK));
>>
>> Shouldn't this also be a hweight64() != 1 check ?
>
> What about SINGLE profile on disk?
> It doesn't has any profile bit set.
Agh, it's implied, doesn't even have a define. Then it's fine I guess,
huhz so many "special cases" ...
Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>
>
> Thanks,
> Qu
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
